Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to resolve noble based CI fixes #96

Merged
merged 19 commits into from
Apr 13, 2024
Merged

Trying to resolve noble based CI fixes #96

merged 19 commits into from
Apr 13, 2024

Conversation

tfoote
Copy link
Member

@tfoote tfoote commented Apr 10, 2024

No description provided.

@rkent
Copy link
Contributor

rkent commented Apr 11, 2024

You would probably know better than me, but after reading the material on the changes to python, it seems to me the instructions to users needs to be in ubuntu 24 (and no reason not to do that earlier):

  • install rosdoc2 using pipx
  • test rosdoc2 with a venv and pip install -e .[test]

I really don't think that PIP_BREAK_SYSTEM_PACKAGES: 1 is what we are going to recommend to users. Is there any reason to prefer that over venv in the github runner?

@tfoote
Copy link
Member Author

tfoote commented Apr 11, 2024

Yeah we don't want to ask users to do that. It's only necessary for flake8 unfortunately.

There's a new proposed approach at: ros-infrastructure/rosdep#930 I haven't had a chance to review yet.

@tfoote tfoote marked this pull request as ready for review April 13, 2024 00:03
@tfoote tfoote requested a review from audrow as a code owner April 13, 2024 00:03
@tfoote
Copy link
Member Author

tfoote commented Apr 13, 2024

I'm going to squash this as it is to get is back to green. We're pushing hard to get the noble image to have flake8 in a working format via apt before Noble is finalized.

@tfoote tfoote merged commit 2b8a379 into main Apr 13, 2024
4 checks passed
@tfoote tfoote deleted the tfoote-patch-1 branch April 13, 2024 00:05
@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/plans-for-ros-2-documentation-particularly-api-docs/28638/32

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/plans-for-ros-2-documentation-particularly-api-docs/28638/34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants